Add GitHub action CI builds #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeShirley
requested review from
WestonHanners and
EricBAndrews
and removed request for
a team
JakeShirley
changed the title
JakeShirley
commented
Sep 9, 2023
JakeShirley
commented
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- No issues for this
Pull Request Information
About this Pull Request
This PR adds two new GitHub Action jobs:
xcodebuildxcodebuildIt also disabled the UI tests project from running as it sounds like that is a waste of time and a stubbed out empty project.
Screenshots and Videos
n/a
Additional Context
This PR hard codes a specific device to build and test on in the iOS simulator (iPhone 14) as well as an iOS version string.
These will change over time when GitHub updates their MacOS agents but I added a step which prints available combinations so updating will be easy. These values should be pretty stable (months between changing, not weeks) but we could probably automate the selection somehow with some fancy grep.