Fix iPad share #579
Merged
Fix iPad share #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBAndrews
requested review from
WestonHanners and
mormaer
and removed request for
a team
boscojwho
reviewed
Sep 7, 2023
boscojwho
reviewed
Sep 7, 2023
EricBAndrews
force-pushed
the
eric/ipad-share
branch
from
d2829c2 to
a831de5
Compare
EricBAndrews
force-pushed
the
eric/ipad-share
branch
from
a831de5 to
74a9148
Compare
JakeShirley
approved these changes
Sep 10, 2023
EricBAndrews
force-pushed
the
eric/ipad-share
branch
from
74a9148 to
b430b84
Compare
Closed
boscojwho
pushed a commit
to boscojwho/mlem
that referenced
this pull request
Sep 16, 2023
boscojwho
pushed a commit
that referenced
this pull request
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- Crash on iPad share #578
Pull Request Information
This PR addresses an issue where sharing from iPad would crash the app. This was due to the use of
showShareSheet, which was not iPad-compatible. This PR replaces all instance ofshowShareSheetwith aShareLink.To support this, it also performs a refactor of how menu items work:
MenuFunctionis now an enum with an associated type, eitherShareMenuFunctionorStandardMenuFunction.MenuButtonnow displays aShareLinkforMenuFunction.shareand a regular menu button forMenuFunction.standard.ViewModifierfor easy reuse, and have been populated everywhere they're needed