Mod Mail Reports #1519
Open
Mod Mail Reports #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjmarf
requested review from
JakeShirley and
mormaer
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on this MlemMiddleware PR.
Closes #1504. There is no content loader model yet - just some temporary code to display the first page of results. Issue here.
Reports look like this. In future the interaction bar will be customizable, but I haven't implemented this yet. Issue here.
On versions prior to 0.19.4, significantly less information is included in the report responses. This makes us unable to create
Post2/Comment2models on those versions, and instead we have to fallback toPost1/Comment1models.As a result, on 0.19.3 and below the reports instead look like this:
The biggest downgrade here is that there is no ellipsis menu from which you can take action on the content. To do that, you have to tap on the report to open the post/comment and take action on it from there. Now, this downgrade isn't actually a limitation of the missing data - we could still include those ellipsis menus, but doing so would require a significant amount of work and I don't think it's worth it.