Fullscreen Image #1499
Merged
Fullscreen Image #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBAndrews
requested review from
WestonHanners,
JakeShirley and
Sjmarf
and removed request for
a team
|
Swipe to dismiss doesn't seem to be working for me on my physical device 🤔 |
EricBAndrews
force-pushed
the
eric/fullscreen-image
branch
from
ed67435 to
195ade6
Compare
Sjmarf
requested changes
Dec 15, 2024
It is still used--the overlay needs to be a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- closes [2.0] Image jumps to the left when closing preview #1354
Pull Request Information
This PR replaces the sheet-based image viewer with an overlay-based implementation. It can be swiped away either up or down, and interactive dismissal works on iPad now too.
I've also moved the audio button to the bottom to avoid conflict with the close button.