Sort Picker Changes

[Sjmarf]

This is just the sort picker stuff - I haven't moved filters (e.g. "Hide read" etc) here yet.

Closes #1212
Closes #1217

If there are any unavailable sort modes, they're shown at the bottom of the list.

[EricBAndrews]

Code looks good!

The design is very nice too--my only note is that the pin button being in a separate column feels a bit off. Some alternative ideas:

• Color/fill the icon of the selected sort instead of the checkmark; we'd need a colorblind mode alternative, since fill is not available for scaled (or we find a new icon--megaphone, maybe?)
• Shade the background of the selected sort

[Sjmarf]

my only note is that the pin button being in a separate column feels a bit off. Some alternative ideas:

Sure, I can try those. How do you propose that the user changes whether an item is pinned or not? Via context menu? Currently, tapping the pin button toggles the pin state and tapping the sort mode itself selects it.

[EricBAndrews]

Tapping the pin still seems like the way to go--we can also put it on a swipe action

[Sjmarf]

How's this?

I'd rather avoid using only icon fill state to denote selection when we've got lots of different icons - it's much more difficult at a glance to see which is selected (to my eye, anyway).

[EricBAndrews]

LGTM! 🔥