Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Settings #1484

Merged
merged 9 commits into from
Dec 9, 2024
Merged

Profile Settings #1484

merged 9 commits into from
Dec 9, 2024

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented Dec 7, 2024

Closes #1411. Relies on this MlemMiddleware PR.

@Sjmarf Sjmarf requested a review from a team as a code owner December 7, 2024 20:22
@Sjmarf Sjmarf requested review from mormaer and EricBAndrews and removed request for a team December 7, 2024 20:22
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

I've flagged a couple missing Icons instances.

Mlem.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Mlem/App/Views/Shared/ImageUploadMenu.swift Outdated Show resolved Hide resolved
@Sjmarf Sjmarf enabled auto-merge (squash) December 9, 2024 21:55
@Sjmarf Sjmarf merged commit 3daecd4 into dev Dec 9, 2024
2 checks passed
@Sjmarf Sjmarf deleted the sjmarf/profile-settings2 branch December 9, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile Settings
2 participants