Infinite Loading Inbox #1478
Merged
Infinite Loading Inbox #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBAndrews
requested review from
WestonHanners and
JakeShirley
and removed request for
a team
Sjmarf
requested changes
Dec 7, 2024
There was a problem hiding this comment.
Found a few bugs:
- The "inbox is outdated" popup isn't shown anymore when the tab badge count changes.
- The "Load more" button flashes briefly when loading a new page.
- The inbox doesn't respect the "Infinite scroll" setting - is this intentional?
This PR closes #1479 💯
Yes. The theory is that manual page loading is a time management tool, but since people don't really "scroll" their inbox like they do a feed it doesn't make sense in that context. |
This one was a middleware issue--fixed here. It was a super trivial change (just needed to move the loading state assignment to after the item assignment), so I went ahead and merged the middleware side--if there are other issues that need a middleware fix I'll open a new one |
Co-authored-by: Sjmarf <[email protected]>
Co-authored-by: Sjmarf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- closes Infinite inbox loading #1432
Pull Request Information
Frontend changes for mlemgroup/MlemMiddleware#74.
Mostly just updates to use
InboxFeedLoaderand friends. The main notable change is that items are not all hidden when "mark all as read" is used. This is consistent with how the feed behaves when read items are filtered out and the user marks an item as read (i.e., it remains visible)This PR also includes a minor tweak to show the media type indicator when developer mode is active, rather than guarding it in
#DEBUG. This should make daily driving a local dev build nicer, plus offer that insight in the production app as well if needed.