Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand comments inline #1464

Merged
merged 4 commits into from
Dec 7, 2024
Merged

Expand comments inline #1464

merged 4 commits into from
Dec 7, 2024

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented Nov 28, 2024

Closes #1451

@Sjmarf Sjmarf requested a review from a team as a code owner November 28, 2024 11:16
@Sjmarf Sjmarf requested review from WestonHanners and mormaer and removed request for a team November 28, 2024 11:16
@Sjmarf Sjmarf marked this pull request as draft November 28, 2024 11:17
@Sjmarf Sjmarf marked this pull request as ready for review November 29, 2024 09:54
EricBAndrews
EricBAndrews approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Sjmarf Sjmarf enabled auto-merge (squash) December 7, 2024 14:23
@Sjmarf Sjmarf merged commit 8295865 into dev Dec 7, 2024
2 checks passed
@Sjmarf Sjmarf deleted the sjmarf/expand-comments-inline branch December 7, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBAndrews EricBAndrews EricBAndrews approved these changes

@WestonHanners WestonHanners Awaiting requested review from WestonHanners WestonHanners is a code owner automatically assigned from mlemgroup/mlem-dev-team

@mormaer mormaer Awaiting requested review from mormaer mormaer is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When clicking "more replies", expand comments inline in most cases
2 participants
@Sjmarf @EricBAndrews