added unit tests

mlemgroup · Oct 1, 2023 · 3e1b257 · 3e1b257
1 parent 561c6b2
commit 3e1b257
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 10 deletions.
diff --git a/Mlem/Models/Trackers/RecentSearchesTracker.swift b/Mlem/Models/Trackers/RecentSearchesTracker.swift
@@ -24,7 +24,7 @@ class RecentSearchesTracker: ObservableObject {
 
         recentSearches = .init()
         if let accountHash = apiClient.accountHash {
-            let identifiers = persistenceRepository.loadRecentSearches(accountHash: accountHash)
+            let identifiers = persistenceRepository.loadRecentSearches(for: accountHash)
 
             for id in identifiers {
                 print(id.contentType, id.contentId)

diff --git a/Mlem/Repositories/PersistenceRepository.swift b/Mlem/Repositories/PersistenceRepository.swift
@@ -83,7 +83,7 @@ class PersistenceRepository {
         try await save(value, to: Path.savedAccounts)
     }
 
-    func loadRecentSearches(accountHash: Int) -> [ContentModelIdentifier] {
+    func loadRecentSearches(for accountHash: Int) -> [ContentModelIdentifier] {
         let searches = load([Int: [ContentModelIdentifier]].self, from: Path.recentSearches) ?? [:]
         return searches[accountHash] ?? []
     }

diff --git a/MlemTests/Persistence/PersistenceRepositoryTests.swift b/MlemTests/Persistence/PersistenceRepositoryTests.swift
@@ -122,24 +122,30 @@ final class PersistenceRepositoryTests: XCTestCase {
     func testSaveRecentSearches() async throws {
         let searches: [ContentModelIdentifier] = [.init(contentType: .user, contentId: 1), .init(contentType: .community, contentId: 2)]
 
-        try await repository.saveRecentSearches(searches) // write the examples to disk
-        let searchesFromDisk = try load([ContentModelIdentifier].self) // load them from the disk _without_ using the repository
+        try await repository.saveRecentSearches(for: 1, with: searches) // write the examples to disk
+        let searchesFromDisk = try load([Int: [ContentModelIdentifier]].self) // load them from the disk _without_ using the repository
 
-        XCTAssertEqual(searches, searchesFromDisk) // confirm what was written to disk matches what we sent in
+        let expected: [Int: [ContentModelIdentifier]] = [1: searches]
+        XCTAssertEqual(expected, searchesFromDisk) // confirm what was written to disk matches what we sent in
     }
 
     func testLoadRecentSearchesWithValues() async throws {
-        let searches: [ContentModelIdentifier] = [.init(contentType: .user, contentId: 1), .init(contentType: .community, contentId: 2)]
+        let searches1: [ContentModelIdentifier] = [.init(contentType: .user, contentId: 1), .init(contentType: .community, contentId: 2)]
+        let searches2: [ContentModelIdentifier] = [.init(contentType: .user, contentId: 2), .init(contentType: .community, contentId: 3)]
+
+        try await repository.saveRecentSearches(for: 1, with: searches1)
+        try await repository.saveRecentSearches(for: 2, with: searches2)
 
-        try await repository.saveRecentSearches(searches) // write the example terms to the disk
-        let loadedSearches = repository.loadRecentSearches() // read them back
+        let loadedSearches1 = repository.loadRecentSearches(accountHash: 1) // read them back
+        let loadedSearches2 = repository.loadRecentSearches(accountHash: 2)
 
-        XCTAssertEqual(loadedSearches, searches) // assert we were given the same values back
+        XCTAssertEqual(loadedSearches1, searches1) // assert we were given the same values back
+        XCTAssertEqual(loadedSearches2, searches2)
     }
 
     func testLoadRecentSearchesWithoutValues() async throws {
         XCTAssert(disk.isEmpty) // assert that our mock disk has nothing in it
-        let loadedSearches = repository.loadRecentSearches() // perform a load knowing the disk is empty
+        let loadedSearches = repository.loadRecentSearches(accountHash: 1) // perform a load knowing the disk is empty
         XCTAssert(loadedSearches.isEmpty) // assert we were returned an empty list
     }