- Updated icon for collapse comment settings

- Updated collapseComment flag name to be more consistent
mlemgroup · Jan 3, 2024 · 25a70ba · 25a70ba
1 parent 5c36133
commit 25a70ba
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/Mlem/API/Internal/HierarchicalComment.swift b/Mlem/API/Internal/HierarchicalComment.swift
@@ -164,7 +164,7 @@ extension [APICommentView] {
 
         /// Recursively populates child comments by looking up IDs from `childrenById`
         func populateChildren(_ comment: APICommentView) -> HierarchicalComment {
-            let collapseChildCommentsFlag = UserDefaults.standard.bool(forKey: "collapseCommentReplies")
+            let collapseChildCommentsFlag = UserDefaults.standard.bool(forKey: "collapseChildComments")
             // Collapse all child comments and excluse parents comments
             let isCollapsed = collapseChildCommentsFlag && !(comment.comment.parentId == nil)
 

diff --git a/Mlem/Icons.swift b/Mlem/Icons.swift
@@ -9,7 +9,7 @@ import Foundation
 import SwiftUI
 
 /// SFSymbol names for icons
-struct Icons {
+enum Icons {
     // votes
     static let votes: String = "arrow.up.arrow.down.square"
     static let upvote: String = "arrow.up"
@@ -183,6 +183,7 @@ struct Icons {
     static let developerMode: String = "wrench.adjustable.fill"
     static let limitImageHeightSetting: String = "rectangle.compress.vertical"
     static let swipeUpGestureSetting: String = "arrow.up.to.line.alt"
+    static let collapseComments: String = "arrow.down.and.line.horizontal.and.arrow.up"
 
     // misc
     static let switchUser: String = "person.crop.circle.badge.plus"

diff --git a/Mlem/Views/Tabs/Settings/Components/Views/Appearance/Comment/CommentSettingsView.swift b/Mlem/Views/Tabs/Settings/Components/Views/Appearance/Comment/CommentSettingsView.swift
@@ -51,7 +51,7 @@ struct CommentSettingsView: View {
     @AppStorage("shouldShowUserServerInComment") var shouldShowUserServerInComment: Bool = false
 
     @AppStorage("showCommentJumpButton") var showCommentJumpButton: Bool = true
-    @AppStorage("collapseCommentReplies") var collapseChildComments: Bool = false
+    @AppStorage("collapseChildComments") var collapseChildComments: Bool = false
     @AppStorage("commentJumpButtonSide") var commentJumpButtonSide: JumpButtonLocation = .bottomTrailing
 
     var body: some View {
@@ -117,7 +117,7 @@ struct CommentSettingsView: View {
                     isTicked: $showCommentJumpButton
                 )
                 SwitchableSettingsItem(
-                    settingPictureSystemName: Icons.absent,
+                    settingPictureSystemName: Icons.collapseComments,
                     settingName: "Automatically Collapse Replies",
                     isTicked: $collapseChildComments
                 )