Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLPerf Llama2] update llama2 reference fp32 accuracy #1583

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

nvzhihanj
Copy link
Contributor

@nvzhihanj nvzhihanj commented Jan 25, 2024

Address #1558

Old accuracy metrics: {'rouge1': 43.88, 'rouge2': 21.7108, 'rougeL': 28.2502, 'tokens_per_sample': 293.3}

New accuracy metrics: {'rouge1': 44.4312, 'rouge2': 22.0352, 'rougeL': 28.6162, 'tokens_per_sample': 294.45}

@nvzhihanj nvzhihanj requested a review from a team as a code owner January 25, 2024 21:26
Copy link

github-actions bot commented Jan 25, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@arjunsuresh arjunsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update.

@pgmpablo157321
Copy link
Contributor

pgmpablo157321 commented Jan 25, 2024

@nvzhihanj Could you open a PR to modify the values here as well?

@FanhaiLu1
Copy link

@nvzhihanj Can you add a Accuracy Target for calibration dataset? I do prefer to get a quick accuracy result with a trustable small dataset.

@nvzhihanj
Copy link
Contributor Author

@nvzhihanj Could you open a PR to modify the values here as well?

Opened mlcommons/inference_policies#289

@nvzhihanj
Copy link
Contributor Author

nvzhihanj commented Jan 25, 2024

@nvzhihanj Can you add a Accuracy Target for calibration dataset? I do prefer to get a quick accuracy result with a trustable small dataset.

@FanhaiLu1 Please get the reference log here: https://drive.google.com/file/d/14uTgBCGjMRKddSNAYkeFeKPtpl2-ft9m/view?usp=sharing. You can run a subset of it and compare to that subset with the reference log.

@pgmpablo157321 pgmpablo157321 merged commit 180014a into mlcommons:master Jan 26, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants