Dev #1195
Closed
Dev #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
commented
Apr 11, 2024
| @@ -1716,6 +1723,16 @@ def _run(self, i): | |||
| if verbose or show_time: | |||
| print (recursion_spaces+' - running time of script "{}": {:.2f} sec.'.format(','.join(found_script_tags), elapsed_time)) | |||
|
|
|||
|
|
|||
| if not recursion and (verbose or show_space): | |||
| stop_disk_stats = shutil.disk_usage("/") | |||
There was a problem hiding this comment.
Will this be a problem on huge NFS mounts?
There was a problem hiding this comment.
Will this be a problem on huge NFS mounts?
Very good point. Could be! I changed this line and calculate space only if explicitly requested by --space flag. It's still a very useful feature when I test scripts for datasets and models - it's now very easy to see the used space consumed by the script ...
…" XYZ to create virtual env
(as suggested by Arjun)
|
I will close it for now and will reopen later since I need to do more fixes ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.