Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plutus-ledger-api V2 #55

Merged
merged 41 commits into from
Nov 7, 2024
Merged

plutus-ledger-api V2 #55

merged 41 commits into from
Nov 7, 2024

Conversation

szg251
Copy link
Collaborator

@szg251 szg251 commented Oct 4, 2024 •
edited by chfanghr
Loading

szg251 and others added 30 commits August 28, 2024 11:10
@szg251
Implement extra golden tests for external use
2b7d884
@szg251
Update golden tests
fb8cc8e
@szg251
Custom serde serialization for Value
e9adfe8
@szg251
Add Display implementations
fcbf520
@szg251
Reorganise modules
bf30fbc
@szg251
Apply clippy suggestions
c60e631
@szg251
Update csl
7864eb2
@szg251
Changelog and version bump
9274576
@chfanghr
implement procedural derive macro for IsPlutusData
87e07ef
@chfanghr
separate PlutusData and IsPlutusData from plutus-ledger-api
21efc52
@chfanghr
lower version requirement of proc-macro2
1a7c261
@chfanghr
plutus_data_derive_strategy -> is_plutus_data_derive_strategy
167395f
@chfanghr
fix parse_fixed_len_plutus_data_list not in scope
4d5a08b
@chfanghr
attribute value can only be literal
001c558
@chfanghr
derive the shit out of it
c7812dd
@chfanghr
explicitly mark derive strategies
b4351b7
@chfanghr
move plutus-data back to where it was
3e64281
@chfanghr
remove plutus-data
84f92b6
@chfanghr
fogot to commit .envrc
e84bbb0
@chfanghr
update changelog
32b00e6
@chfanghr
add v3 types
2fd89e1
@chfanghr
implement generators for v3 types
9895366
@chfanghr
add property tests for v3 types
688be1c
@chfanghr
explicitly mark derive strategies
6864a9a
@chfanghr
remove true from dependencies
e727987
@chfanghr
doc strings
2d51d1c
@chfanghr
more doc strings
e96c707
@chfanghr
even more doc strings
cf119ba
@chfanghr
update changelog
413e2e7
@szg251
Merge pull request #56 from mlabs-haskell/connor/is_plutus_data_derive
62a1ce5 
Derive `IsPlutusData`
@szg251 szg251 changed the title Some improvements that were hanging in the background plutus-ledger-api V2 Nov 5, 2024
@szg251 szg251 marked this pull request as ready for review November 5, 2024 16:39
@szg251 szg251 requested a review from chfanghr November 5, 2024 16:39
chfanghr
chfanghr suggested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@chfanghr chfanghr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUGE

plutus-ledger-api/src/v1/value.rs Outdated Show resolved Hide resolved
plutus-ledger-api/src/v1/value.rs Outdated Show resolved Hide resolved
plutus-ledger-api/src/v1/value.rs Outdated Show resolved Hide resolved
plutus-ledger-api/src/v1/value.rs Outdated Show resolved Hide resolved
plutus-ledger-api/src/v1/value.rs Outdated Show resolved Hide resolved
plutus-ledger-api/src/v1/value.rs Show resolved Hide resolved
plutus-ledger-api/src/v3/mod.rs Show resolved Hide resolved
plutus-ledger-api/tests/display.proptest-regressions Outdated Show resolved Hide resolved
@szg251 szg251 requested a review from chfanghr November 7, 2024 14:03
chfanghr
chfanghr approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@chfanghr chfanghr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing doc strings! Thanks!

plutus-ledger-api/src/aux.rs Outdated
@@ -75,6 +80,8 @@ pub fn guard_bytes(ctx: &str, bytes: Vec<u8>, expected: usize) -> Result<Vec<u8>
}
}

/// Nom parser for BigInt
/// Expects an arbitrary length integer, optionally signed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decimal numbers

plutus-ledger-api/tests/display.proptest-regressions Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no it's coming back

@szg251 szg251 merged commit 0f79249 into main Nov 7, 2024
2 checks passed
@szg251 szg251 deleted the szg251/improvements branch November 7, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfanghr chfanghr chfanghr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szg251 @chfanghr