Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace deprecated request-promise with axios #1382

Merged
merged 1 commit into from
May 20, 2022
Merged

replace deprecated request-promise with axios #1382

merged 1 commit into from
May 20, 2022

Conversation

lindapaiste
Copy link
Contributor

Related: #1260

Removes devDependency request-promise which is deprecated. Replaces the usages of request-promise in scripts/batch-update-p5webeditor.js with axios.request().

THIS IS UNTESTED as I don't know how to execute this file with the correct environment variables.

@lindapaiste lindapaiste added devops dependencies Pull requests that update a dependency file labels May 9, 2022
@lindapaiste lindapaiste requested review from joeyklee and bomanimc May 9, 2022 01:34
joeyklee
joeyklee approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@joeyklee joeyklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this! Likely we would need to rewrite this anyways if/when there would be a time we start doing batch updates to the p5 web editor again 🙈 but anyhow, good to cleanup those deprecated dependencies.

@joeyklee joeyklee added the SEMVER/patch a version tag for a patch release change label May 20, 2022
@joeyklee joeyklee merged commit f7fe8a6 into ml5js:main May 20, 2022
@lindapaiste lindapaiste deleted the fix/rp-axios branch May 20, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyklee joeyklee joeyklee approved these changes

@bomanimc bomanimc Awaiting requested review from bomanimc

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file devops SEMVER/patch a version tag for a patch release change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lindapaiste @joeyklee