Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Added] Kronecker Product #1728

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Added] Kronecker Product #1728

wants to merge 3 commits into from

Conversation

cvnad1
Copy link
Contributor

@cvnad1 cvnad1 commented Dec 21, 2024

Proposed changes

Added Kronecker Product to the MLX core and also added the tests as discussed in #1540

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@cvnad1
Copy link
Contributor Author

cvnad1 commented Dec 21, 2024

Hey @angeloskath,
I apologize for the delay in adding the implementation of kronecker product. Took some time to navigate and finally have added the implementation. Please review the changes and kindly merge the PR if everything looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant