Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io/load: Enabled pread implementation for mingw32 #1706

Merged
merged 1 commit into from
Dec 16, 2024
Merged

io/load: Enabled pread implementation for mingw32 #1706

merged 1 commit into from
Dec 16, 2024

Conversation

stemann
Copy link
Contributor

@stemann stemann commented Dec 16, 2024

Proposed changes

Enables pread implementation #1666 for mingw32.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@stemann stemann force-pushed the feature/io_load_mingw32 branch from 3cf77b0 to 529a5e8 Compare December 16, 2024 10:06
awni
awni approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@awni awni merged commit a82996e into ml-explore:main Dec 16, 2024
6 checks passed
@zcbenz zcbenz mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awni awni awni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stemann @awni