Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Py_ssize_t in python bindings #1678

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Dec 9, 2024

Refs #1513.

Same with #1673 that the use of ssize_t has to be replaced. In this PR I use Py_ssize_t instead since they are going to be assigned to Py_buffer and other types do not compile.

This PR also includes a tiny fix that too small to be a separate PR.

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!!

@awni awni merged commit 87d7a25 into ml-explore:main Dec 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants