Build OpenBLAS from source code for MSVC #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awni
reviewed
Dec 10, 2024
| if(WIN32) | ||
| if(MSVC) |
There was a problem hiding this comment.
I'm just curious why we check both of these. Is it common to use a compiler other than MSVC on windows?
There was a problem hiding this comment.
Some people use MinGW (JuliaPackaging/Yggdrasil#9761), which provides layers for some POSIX APIs.
awni
reviewed
Dec 10, 2024
stemann
reviewed
Dec 14, 2024
| target_link_libraries(mlx PUBLIC ${BLAS_LIBRARIES}) | ||
|
|
||
| if(WIN32) | ||
| find_package(dlfcn-win32 REQUIRED) |
There was a problem hiding this comment.
Sorry to see this gone!
A USE_SYSTEM_DLFCN_WIN32 option could have kept it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1513.
When building with MSVC, there is no central package manager that allows installing and searching third party packages, so we can not find BLAS with
find_package.This PR adds a
MLX_BUILD_BLAS_FROM_SOURCEflag to download and build OpenBLAS from source code which is turned on for MSVC by default. Other platforms can also set it on to test the same build.The
dlfcn-win32dependency is also changed to build from source for the same reason.