Fix library output directory for MSVC

.gitignore

@@ -76,6 +76,9 @@ build/
 *.out
 *.app
 
+# Debug symbols
+*.pdb
+
 # VSCode 
 .vscode/
 .DS_Store

python/src/CMakeLists.txt

@@ -29,8 +29,21 @@ if(NOT MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY)
   set(MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
 endif()
 
-set_target_properties(core PROPERTIES LIBRARY_OUTPUT_DIRECTORY
-                                      ${MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY})
+if(MSVC)
+  set_target_properties(
+    core
+    PROPERTIES LIBRARY_OUTPUT_DIRECTORY_RELEASE
+               ${MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY}
+               LIBRARY_OUTPUT_DIRECTORY_DEBUG
+               ${MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY}
+               LIBRARY_OUTPUT_DIRECTORY_RELWITHDEBINFO
+               ${MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY}
+               LIBRARY_OUTPUT_DIRECTORY_MINSIZEREL
+               ${MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY})
+else()
+  set_target_properties(core PROPERTIES LIBRARY_OUTPUT_DIRECTORY
+                                        ${MLX_PYTHON_BINDINGS_OUTPUT_DIRECTORY})
+endif()
 
 target_link_libraries(core PRIVATE mlx)
 target_compile_definitions(core PRIVATE _VERSION_=${MLX_VERSION})

setup.py

@@ -91,6 +91,10 @@ def build_extension(self, ext: CMakeExtension) -> None:
                 # CMake 3.12+ only.
                 build_args += [f"-j{self.parallel}"]
 
+        # MSVC requires explcitly passing config when building.
+        if sys.platform in ["win32", "cygwin"]:
+            build_args += ["--config", cfg]
+
         build_temp = Path(self.build_temp) / ext.name
         if not build_temp.exists():
             build_temp.mkdir(parents=True)