Do not pass integers to isnan (#1664)

ml-explore · Dec 8, 2024 · 6ae5423 · 6ae5423
1 parent 9635cff
commit 6ae5423
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/mlx/backend/common/ops.h b/mlx/backend/common/ops.h
@@ -500,7 +500,12 @@ struct Equal {
 struct NaNEqual {
   template <typename T>
   bool operator()(T x, T y) {
-    return x == y || (std::isnan(x) && std::isnan(y));
+    if constexpr (std::is_integral_v<T>) {
+      // isnan always returns false for integers, and MSVC refuses to compile.
+      return x == y;
+    } else {
+      return x == y || (std::isnan(x) && std::isnan(y));
+    }
   }
 };