Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to assign EmptyCPUs to cpus if there is a permission error #139

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Make sure to assign EmptyCPUs to cpus if there is a permission error #139

merged 1 commit into from
Nov 27, 2024

Conversation

wbjin
Copy link
Collaborator

@wbjin wbjin commented Nov 27, 2024

When cpu_indices=None for initializing ZeusMonitor and there is a permission error (not run with sudo), make sure to assign self.cpus = EmptyCPUs()

jaywonchung
jaywonchung approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@jaywonchung jaywonchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jaywonchung jaywonchung merged commit 2c7c5a7 into master Nov 27, 2024
3 checks passed
@jaywonchung jaywonchung deleted the fix-cpu-assignment-no-permission branch November 27, 2024 04:38
parthraut pushed a commit that referenced this pull request Dec 9, 2024
@wbjin @parthraut
[Fix] Assign EmptyCPUs on permission error (#139)
a5e20f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaywonchung jaywonchung jaywonchung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbjin @jaywonchung