Movie view page #31
Merged
Movie view page #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmyMorris
reviewed
Jul 10, 2021
| movie_details = JSON.parse(response.body, symbolize_names: true) | ||
| Movie.new(movie_details) | ||
| end | ||
| end |
There was a problem hiding this comment.
Great Job!! This looks awesome!
EmmyMorris
reviewed
Jul 10, 2021
| <h4>Author: <%= review[:author] %></h4> | ||
| <p><%= review[:content] %></p> | ||
| <% end %> | ||
| </p> |
There was a problem hiding this comment.
This also looks really good!
EmmyMorris
approved these changes
Jul 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
No movie view page exists.
Issue Number: #8
What is the new behavior?
Does this introduce a breaking change?
Other information
Please take a look at my design decisions and see if you agree with them! I'm not so sure about the Movie PORO but it does make the view look a lot nice. Definitely something I'm planning to ask Brian about on Monday.