fix: module indent can be negative #11
Conversation
|
I think it might be useful to print the error with https://crates.io/crates/serde_path_to_error as it was easier to tell what the issue was with using this crate. Otherwise it only printed to whole json response, and that it didn't match the Enum. Which isn't useful at all. |
There was a problem hiding this comment.
Thanks! There have been similar issues in the past due to our strong types and some moodle instances not matching the docs.
I think it might be useful to print the error with https://crates.io/crates/serde_path_to_error as it was easier to tell what the issue was with using this crate. Otherwise it only printed to whole json response, and that it didn't match the Enum. Which isn't useful at all.
Sounds good! Would you like to tackle this or open an issue? If you'd like to work on this soon, I'd wait with a release containing this fix.
mkroening
force-pushed
the
fix/indent
branch
from
2963a8d to
f930c62
Compare
|
@mkroening will take a look at it today, when I debugged it I didn't implement it perfectly, so I'll see what I can do! |
Awesome, thanks! :) |
Synchronization of a course failed, as a module contained a negative indentation (-1) on the WebSite it looks like the indentation 1, but edu-sync doesn't do anything with the indent, so it's not that important.
Fixes #10