Identification, tag normalization and private_fields API enhancements released #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompletion message
…g_string_autocomplete)
…nfig options - Improve before_dataset_search and after_dataset_search to avoid exposing private_fields - Improve dataset_show to clean up private_fields - Add options to config_declaration to configure private_fields and roles that have access to private_fields. - Improve docs.
mjanez
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
ckanext/schemingdcatextension, focusing on new features, bug fixes, and code improvements. The main changes involve the addition of private fields handling in the API, new CSS styles, and updates to the configuration and validation patterns.New Features:
ckanext/schemingdcat/config_declaration.yml: Added API settings for private fields and roles that can access them.ckanext/schemingdcat/schemas/default_presets.json: Introduced new presets for tag normalization and required multiple text fields.Bug Fixes:
ckanext/schemingdcat/helpers.py: Fixed a bug inschemingdcat_user_is_org_memberto handle cases where the user is not provided.Code Improvements:
ckanext/schemingdcat/package_controller.py: Enhanced search and view methods to remove private fields from API responses and improved the handling of private fields in search parameters.ckanext/schemingdcat/utils.py: Added a utility functionremove_private_keysto clean private fields from data dictionaries.Styling Updates:
ckanext/schemingdcat/assets/css/schemingdcat.css: Added a new CSS variable for grey color and a.text-mutedclass for muted text styling.Configuration and Validation:
ckanext/schemingdcat/config/__init__.py,ckanext/schemingdcat/config/tools.py: Added a new regular expression patternTAGS_NORMALIZE_PATTERNfor tag normalization.ckanext/schemingdcat/validators.py: ImportedTAGS_NORMALIZE_PATTERNfor use in validation.