fix bug where join_timeout would kill the subprocess on first timeout #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since join_timeout does no longer consume the handle, killing it on timeout is not appropriate. instead move that to a drop impl also add test for new join_timeout behavior
untitaker
force-pushed
the
fix/join-timeout-pool
branch
from
9657aee to
d3c91e1
Compare
|
summary from slack: it's not clear that reusing join_timeout after timeout actually is safe at all, depending on the implementation of timeouts in ipc-channel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since join_timeout does no longer consume the handle, killing it on
timeout is not appropriate. instead move that to a drop impl
also add test for new join_timeout behavior