Integrating DBT with Superset #1073
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dbt_cli_resource. Adding new ops to open_edx. New op to sync dbt and superset datasets. New op to push dbt metadata to superset.
blarghmatey
reviewed
Apr 11, 2024
Comment on lines
+58
to
+60
| # TODO pass a list of dbt tables and superset tables | ||
| sync_superset_data(dbt_tables_marts, superset_tables) | ||
| push_dbt_metadata() |
There was a problem hiding this comment.
These don't seem to belong in this job definition
src/ol_orchestrate/ops/open_edx.py
Outdated
There was a problem hiding this comment.
These don't belong in the open_edx ops. If anything I'd consider creating a module in ops for superset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
mitodl/ol-infrastructure#1968
Description (What does it do?)
Updating elt definitions to use DbtCliResource to replace deprecated dbt_cli_resource.
Adding new ops to open_edx:
New op to sync dbt and superset datasets.
New op to push dbt metadata to superset.
How can this be tested?