Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.170.0 #3369

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Release 0.170.0 #3369

merged 8 commits into from
Jan 14, 2025

Conversation

odlbot
Copy link
Contributor

@odlbot odlbot commented Jan 13, 2025 •
edited by arslanashraf7
Loading

Arslan Ashraf

renovate[bot]

Asad Ali

asadali145 and others added 8 commits January 10, 2025 13:00
@asadali145
refactor: remove COURSE_DROPDOWN flag (#3361)
203a395
@arslanashraf7
feat: Add language support in courses (#3335)
4e83cac 
* feat: Add language support for courses
@asadali145
refactor: remove ENABLE_EXTERNAL_COURSE_SYNC (#3360)
1a6c824 
* refactor: remove ENABLE_EXTERNAL_COURSE_SYNC

* add check for daily sync flag in command

* add force flag to bypass daily sync flag in command

* rename sync_daily to enable_sync

* delete migration

* recreat migration
@asadali145
refactor: remove ENABLE_CATALOG_SORTING (#3359)
c874780
@renovate
chore(deps): update codecov/codecov-action digest to 1e68e06 (#3364)
1992389 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#3366)
4507098 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@arslanashraf7
fix: language not available in course draft pages (#3365)
1d304a0
@odlbot
Release 0.170.0
f71f454
@odlbot odlbot force-pushed the release-candidate branch from 4accc99 to f71f454 Compare January 13, 2025 12:23
@arslanashraf7
Copy link
Contributor

@cachob The release contains the language support except for the frontend.

This is what you should be able to test, the frontend of the language filter will be done in a separate PR via https://github.com/mitodl/hq/issues/6463.

  1. CURD operations of the Course Language can be performed through Django admin https://rc.xpro.mit.edu/admin/courses/courselanguage/
  2. Supported languages mentioned in https://github.com/mitodl/hq/issues/6111 have been pre-filled
  3. The Language model has Priority field, that defines the priority of the language on Catalog sorting (1 would mean the highest priority)
  4. The APIs /api/courses & /api/programs now contain the language key. (You might want to let MIT learn team or other interested parties know about this API change)
  5. Every course or Program Page by default has now been set to English language.
  6. All the existing course and program pages were set to English
  7. The language for the external courses e.g. Emeritus would be synced automatically through their API
  8. The dashboard would be sorted by Language and then the default sort filter present on Catalog.
  9. While testing on RC, I noticed one course that was out of order which was because of bad data. https://rc.xpro.mit.edu/courses/course-v1:xPRO+AIP_PT/. The original language for this course is Portuguese but this course isn't being synced through API because it has BRL which we don't support. For more details https://github.com/mitodl/hq/issues/5972

Please feel free to test it, let others test it and let me know when this is green to go to production.

@cachob
Copy link

cachob commented Jan 14, 2025

@arslanashraf7 - let's go ahead and push to production

@odlbot odlbot merged commit f71f454 into release Jan 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deployed to prod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odlbot @arslanashraf7 @cachob @asadali145