Skip to content

Commit

Permalink
alacritty: --add-rpath instead of --set-rpath
Browse files Browse the repository at this point in the history
As reported by @blucoat in
NixOS#219213 alacritty's RPATH is
missing many of the libraries which it links to, including for
example glibc.

The problem was diagnosed by @kchibisov as being caused by
alacritty's use of `--set-rpath` (which completely replaces the
rpath) instead of `--add-rpath` (which adds additional entries to
the rpath):

  NixOS#219213 (comment)

This commit implements @kchibisov's idea to change `--set-rpath` to
`--add-rpath`:

  NixOS#219213 (comment)

Closes NixOS#219213
  • Loading branch information
Adam Joseph authored and mitchmindtree committed Jul 2, 2023
1 parent 0f481ba commit 0a817c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkgs/applications/terminal-emulators/alacritty/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ rustPlatform.buildRustPackage rec {
# As a workaround, strip manually before running patchelf.
$STRIP -S $out/bin/alacritty
patchelf --set-rpath "${lib.makeLibraryPath rpathLibs}" $out/bin/alacritty
patchelf --add-rpath "${lib.makeLibraryPath rpathLibs}" $out/bin/alacritty
''
) + ''
Expand Down

0 comments on commit 0a817c1

Please sign in to comment.