Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add internationalization support #78

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

feat: add internationalization support #78

wants to merge 26 commits into from

Conversation

mistakia
Copy link
Owner

@mistakia mistakia commented Feb 17, 2024 •
edited
Loading

  • implement http backend and lazy-loading
  • create initial locale resources
    • arabic
    • english
    • german
    • spanish (spain)
    • farsi (iran)
    • french (france)
    • hindi
    • italian
    • japanese
    • korean
    • dutch
    • polish
    • portuguese (portugal)
    • russian
    • turkish
    • vietnamese
    • chinese
    • norweigan
  • serve translations for markdown documents
  • detect browser locale
  • update label page component
  • update contributing.md
  • fix fallback for markdown docs without translations
  • structure markdown docs by document with each document having its own directory of translation files
  • fix menu header titles longer than menu container width

@mistakia mistakia added priority/high High: Likely tackled by core team if no one steps up status/in-progress In progress labels Feb 17, 2024
@mistakia mistakia force-pushed the feat/internationalization branch from 0bb60e4 to 3610847 Compare February 17, 2024 13:34
@mistakia mistakia added the need/triage Needs initial labeling and prioritization label Feb 17, 2024
@mistakia mistakia force-pushed the feat/internationalization branch 5 times, most recently from 14bae33 to 829fe86 Compare February 18, 2024 03:45
@mistakia mistakia added kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization and removed need/triage Needs initial labeling and prioritization labels Feb 18, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 18, 2024
View reviewed changes
api/server.mjs Fixed Show fixed Hide fixed
api/server.mjs Fixed Show fixed Hide fixed
api/server.mjs Fixed Show fixed Hide fixed
@mistakia mistakia force-pushed the feat/internationalization branch 3 times, most recently from f1d32cb to 084457d Compare February 20, 2024 00:51
@coderabbitai coderabbitai

This comment was marked as resolved.

Sign in to view
coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

@mistakia mistakia force-pushed the feat/internationalization branch from 084457d to 25b19d4 Compare February 20, 2024 01:54
coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

@mistakia mistakia removed the need/triage Needs initial labeling and prioritization label Feb 27, 2024
@mistakia mistakia force-pushed the feat/internationalization branch 2 times, most recently from 9649a7d to 7069602 Compare March 1, 2024 03:17
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

2 similar comments
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@mistakia mistakia force-pushed the feat/internationalization branch from 7069602 to 67a020b Compare April 4, 2024 01:54
@mistakia mistakia force-pushed the feat/internationalization branch from be9ab43 to dceeb4e Compare April 20, 2024 23:57
@mistakia mistakia added priority/medium Medium: Good to have, but can wait until someone steps up and removed priority/high High: Likely tackled by core team if no one steps up labels May 12, 2024
@mistakia
Copy link
Owner Author

putting on pause for now as built in browser localization support is pretty good and until there is more community support to review it

@mistakia mistakia added status/deferred Conscious decision to pause or backlog and removed status/in-progress In progress labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature priority/medium Medium: Good to have, but can wait until someone steps up status/deferred Conscious decision to pause or backlog
Projects
Trashman Task Manager
Status: Paused
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mistakia