Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): aiscriptの取得時にSSHでなくHTTPSを使用するように #15067

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

misakazip
Copy link

What

  • pnpmでパッケージをインストール際にSSHでなくHTTPSを使用するように変更
  • lockファイルを更新

Why

SSHを使用すると

Cloning into '/home/runner/setup-pnpm/node_modules/.bin/store/v3/tmp/_tmp_1955_6892ed0aaed91743c3126a2eaf2bcc29'...
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

このActionsなどで発生してしまうから。ただ修正がその場しのぎみたいな感じになってます…

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.33%. Comparing base (dd56623) to head (b6740cb).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15067       +/-   ##
============================================
- Coverage    39.96%   19.33%   -20.64%     
============================================
  Files         1563      728      -835     
  Lines       197744   103800    -93944     
  Branches      3631      991     -2640     
============================================
- Hits         79024    20066    -58958     
+ Misses      118115    83180    -34935     
+ Partials       605      554       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@misakazip misakazip changed the title fix: aiscriptの取得時にSSHでなくHTTPSを使用するように fix(frontend): aiscriptの取得時にSSHでなくHTTPSを使用するように Nov 28, 2024
@kakkokari-gtyih
Copy link
Contributor

これ別のリポジトリで試したのですが依然としてうまくいかなかったのでなにか別の原因があるかもしれません

@misakazip
Copy link
Author

えー…そうなんですか…
謎ですね…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants