-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #24
Open
nicolasmoreau
wants to merge
70
commits into
misdoro:master
Choose a base branch
from
nicolasmoreau:dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev #24
Changes from 39 commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
5227092
rename 'next' buttons in guided query interface
nicolasmoreau 3a5ef6c
consumer service choice is inside the result table
nicolasmoreau fd3395e
simplifies xsams processor choice in result table
nicolasmoreau 92d42ee
removes refresh call to asyncform, as it is not active
nicolasmoreau 3b8acc4
- Improves portal presentation with CSS modifications
nicolasmoreau d68debf
add library
nicolasmoreau b46f2ff
use an older version of sfl4j
nicolasmoreau ab5d84c
add missing . at end of sentence
nicolasmoreau cdaea87
link to nodes on home page
nicolasmoreau c7d7fbb
improve position of elements in advanced query page, solves problems …
nicolasmoreau 87da7d8
changes tables width, removes useless css directive
nicolasmoreau dfd4986
enlarge the page for very long node names
nicolasmoreau 716ac1a
add citation policy page
nicolasmoreau 9e0f1b9
remove list of inactive nodes until the registry has been cleaned
nicolasmoreau 1a27164
reduces width of login form to match new page size
nicolasmoreau 16b94d8
bug correction : problem when displaying saved results for a request …
nicolasmoreau ae82136
type correction
nicolasmoreau a1f3934
Remove "Remove form" link from forms
nicolasmoreau 33316a1
reduces and changes position of european logo
nicolasmoreau b6e4ba8
changes img size in footer
nicolasmoreau c76e605
displays only Molecules in Molecule search form suggestion
nicolasmoreau c76dbdf
corrections in sql requests
nicolasmoreau a959b3f
removes duplicated code
nicolasmoreau 3bc1411
add base class for collisional forms
nicolasmoreau cb28f10
uses renamed methods
nicolasmoreau 9edf50f
solves problem on Remove form functionality
nicolasmoreau d431678
Adds tests for QueryTreeController
nicolasmoreau f938729
correction in clear function call in formtitle form
nicolasmoreau 0a0a16a
adapt java entities to new species database
nicolasmoreau dd88fd0
remove automatic opening of a popup when processor is called
nicolasmoreau cd25d48
New version of portal
nicolasmoreau 6b76c35
Remove trailing System.out
nicolasmoreau 7e8e9c2
close BufferedReader in QueryStore class
nicolasmoreau 8b74e42
remove comments
nicolasmoreau e4d6020
- Do not open a blank tab when downloading a XSAMS file
nicolasmoreau 429c370
Link to download xsams files replaced by a button, enabled only when …
nicolasmoreau 11bc2e2
change entity annotation to point on prod database instead of dev
nicolasmoreau b0379bf
query querystore with https
nicolasmoreau 10d364f
update user agent value
nicolasmoreau 7bda3ae
parameter not renamed in api
nicolasmoreau 87c6ed1
improve code with Misha's remarks
nicolasmoreau 5032b91
fix problem :
nicolasmoreau ceebeff
improves concurrent execution of processors in multiple nodes
nicolasmoreau 080f67f
Fix problems caused by concurrent execution of multiple query store r…
nicolasmoreau f74ebef
add missinig package
nicolasmoreau 3aec723
improve error message display
nicolasmoreau 83e79ee
improves error message display in result table
nicolasmoreau 89285b1
update display of saved requests page by removing stats column ( beca…
nicolasmoreau db205f8
Explicitely instanciate logger in class that are not Seam component
nicolasmoreau bfa2379
change text position on query save page
nicolasmoreau f4cb4c0
Merge branch 'dev'
nicolasmoreau 9b5a8b1
remove comments
nicolasmoreau 359d749
Species search selected by default in guided query mode
nicolasmoreau 6582121
improve display of forms
nicolasmoreau 4b9df13
When converting unit of a wavelength, result is converted to integer …
nicolasmoreau 9fcb42a
Add unit test for WavelengthUnitConverter
nicolasmoreau 0db74fd
Search by species is default option in guided query mode
nicolasmoreau fb89e38
Display "number of atoms / molecules" form in columns instead of lines
nicolasmoreau 0d2214f
Merge branch 'dev'
nicolasmoreau c93356f
When a request is sent to the querystore, its ip address is found in …
nicolasmoreau adf429e
corrections of db name for dev version
nicolasmoreau 10ed816
Add a new Tools page and an entry in the main menu.
nicolasmoreau 97a6a3f
Modification in PreviewThread and PreviewManager classes to handle qu…
nicolasmoreau 596de8b
Takes into account HEAD request returned with a status = 204 but valu…
nicolasmoreau f2a849e
Add a privacy policy page
nicolasmoreau 06623f3
mark not recommended processor explicitely instead of using **
nicolasmoreau 2252b72
urlencode parameter value in request
nicolasmoreau 23aaa8b
https in request to node mirros
nicolasmoreau b717e7f
Modifications in portal to query https services, required a change in…
nicolasmoreau 2874c7b
removes duplicated artifact
nicolasmoreau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
03/04/2017: | ||
Problème avec le clic sur les liens vers les fichiers xsams pour declencher l'association des requêtes dans le querystore. | ||
Le javascript rafraichissant la page ne fonctionnait pas sous firefox. Les liens ont été remplacés par des boutons. | ||
|
||
|
||
13/02/2017: | ||
SEAM retourne des erreurs d'exécution lorsqu'il est lancé avec java8 : | ||
Could not instantiate Seam component: registration | ||
|
||
Le fichier ~/.mavenrc a été édité pour que JAVA_HOME pointe sur java7 | ||
JAVA_HOME est défini dans deploy.sh pour que jboss utilise java7 | ||
|
||
Utilise JSF en version 1.x | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
package org.vamdc.portal.entity; | ||
|
||
import java.util.Collection; | ||
|
||
import javax.persistence.EntityManager; | ||
|
||
/** | ||
|
@@ -10,6 +9,8 @@ | |
* | ||
*/ | ||
class EntityQuery{ | ||
|
||
private EntityQuery(){} | ||
|
||
@SuppressWarnings("unchecked") | ||
static Collection<String> suggestSpeciesName(EntityManager em, | ||
|
@@ -21,7 +22,31 @@ static Collection<String> suggestSpeciesName(EntityManager em, | |
.getResultList(); | ||
|
||
} | ||
|
||
static Collection<String> suggestAtomName(EntityManager em, | ||
String name) { | ||
return suggestRestrictedSpeciesName(em, name, 1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment about magic numbers & constants |
||
|
||
} | ||
|
||
static Collection<String> suggestMoleculeName(EntityManager em, | ||
String name) { | ||
return suggestRestrictedSpeciesName(em, name, 2); | ||
} | ||
|
||
@SuppressWarnings("unchecked") | ||
private static Collection<String> suggestRestrictedSpeciesName(EntityManager em, | ||
String name, Integer speciesType) { | ||
return em.createQuery("SELECT DISTINCT vsn.name from VamdcSpeciesNames vsn JOIN vsn.vamdcSpecies vsp " + | ||
"WHERE vsn.name LIKE :speciesName and vsn.vamdcMarkupTypes.id=1 and vsp.speciesType=:speciesType " | ||
+ " order by length(vsn.name), vsn.searchPriority") | ||
.setParameter("speciesName", "%"+name+"%") | ||
.setParameter("speciesType", speciesType) | ||
.setMaxResults(20) | ||
.getResultList(); | ||
|
||
} | ||
|
||
@SuppressWarnings("unchecked") | ||
static Collection<String> suggestStoichForm(EntityManager em, String formula){ | ||
return em.createQuery("SELECT distinct vs.stoichiometricFormula from VamdcSpecies vs " + | ||
|
@@ -31,14 +56,33 @@ static Collection<String> suggestStoichForm(EntityManager em, String formula){ | |
.getResultList(); | ||
} | ||
|
||
|
||
static Collection<String> suggestMoleculeStoichForm(EntityManager em, String formula){ | ||
return suggestRestrictedStoichForm(em, formula, 2); | ||
} | ||
|
||
@SuppressWarnings("unchecked") | ||
static Collection<String> suggestStructForm(EntityManager em, String formula){ | ||
return em.createQuery("SELECT distinct vssf.formula from VamdcSpeciesStructFormulae vssf " + | ||
"WHERE vssf.formula LIKE :formula and vssf.vamdcMarkupTypes.id=1 order by length(vssf.formula), vssf.searchPriority") | ||
private static Collection<String> suggestRestrictedStoichForm(EntityManager em, String formula, Integer speciesType){ | ||
return em.createQuery("SELECT distinct vs.stoichiometricFormula from VamdcSpecies vs " + | ||
"WHERE vs.stoichiometricFormula LIKE :formula AND vs.speciesType=:speciesType order by length(vs.stoichiometricFormula)") | ||
.setParameter("formula", "%"+formula+"%") | ||
.setParameter("speciesType", speciesType) | ||
.setMaxResults(20) | ||
.getResultList(); | ||
} | ||
|
||
static Collection<String> suggestMoleculeStructForm(EntityManager em, String formula){ | ||
return suggestRestrictedStructForm(em, formula, 2); | ||
} | ||
|
||
@SuppressWarnings("unchecked") | ||
private static Collection<String> suggestRestrictedStructForm(EntityManager em, String formula, Integer speciesType){ | ||
return em.createQuery("SELECT distinct vssf.formula from VamdcSpeciesStructFormulae vssf JOIN vssf.vamdcSpecies vs " + | ||
"WHERE vssf.formula LIKE :formula and vssf.vamdcMarkupTypes.id=1 and vs.speciesType=:speciesType order by length(vssf.formula), vssf.searchPriority") | ||
.setParameter("formula", "%"+formula+"%") | ||
.setParameter("speciesType", speciesType) | ||
.setMaxResults(20) | ||
.getResultList(); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 0 additions & 69 deletions
69
portal.ejb/src/main/java/org/vamdc/portal/entity/species/VamdcConformers.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,18 +6,22 @@ | |
import javax.persistence.Entity; | ||
import javax.persistence.FetchType; | ||
import javax.persistence.GeneratedValue; | ||
|
||
import static javax.persistence.GenerationType.IDENTITY; | ||
|
||
import javax.persistence.Id; | ||
import javax.persistence.JoinColumn; | ||
import javax.persistence.ManyToOne; | ||
import javax.persistence.Table; | ||
|
||
import org.hibernate.validator.NotNull; | ||
import org.vamdc.portal.Settings; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do you need this import here? |
||
|
||
/** | ||
* VamdcInchikeyExceptions generated by hbm2java | ||
*/ | ||
@Entity | ||
@Table(name = "vamdc_inchikey_exceptions", catalog = "vamdc_species") | ||
@Table(name = "vamdc_inchikey_exceptions", catalog = "vamdc_species_dev") | ||
public class VamdcInchikeyExceptions implements java.io.Serializable { | ||
|
||
private Integer id; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to avoid using magic numbers? Like, replace 2 by a named constant...