-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for federation versions up to 2.6 #1158
Add support for federation versions up to 2.6 #1158
Conversation
889ea02
to
935fe27
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 109 109
Lines 7879 7905 +26
=======================================
+ Hits 7712 7738 +26
Misses 167 167 ☔ View full report in Codecov by Sentry. |
8e9153c
to
2d8f466
Compare
2d8f466
to
5756af1
Compare
@rafalp Could you have a look when you got a sec? 🙏 |
ready for another review @rafalp. Thanks! |
Thanks! |
Thanks @rafalp ! May I ask, when are you planning in creating a release? Happy to create a PR to fill in the CHANGELOG if that helps! Thanks! |
When its ready™ Goal is to have query execution over GET in next Ariadne release. When that's merged, I'll cut out a release. |
Awesome, thank you! |
Hey @rafalp ! |
It was already part of 0.23 beta 1, but I'll ship final thing today. |
Added support so we can parse fed 2.4, 2.5 and 2.6. schemas...
Though I haven't added any extra code to mange those new directives or anything like that .
Also, refactored a bit the logic to fallback to the latest avaiable version when using
links
directive, which I think it's better comparing with defaulting to Federation v1