Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for federation versions up to 2.6 #1158

Merged

Conversation

nogates
Copy link
Contributor

@nogates nogates commented Feb 14, 2024

Added support so we can parse fed 2.4, 2.5 and 2.6. schemas...

Though I haven't added any extra code to mange those new directives or anything like that .

Also, refactored a bit the logic to fallback to the latest avaiable version when using links directive, which I think it's better comparing with defaulting to Federation v1

@nogates nogates force-pushed the nogates/add-support-for-fed-versions-up-to-2.6 branch from 889ea02 to 935fe27 Compare February 14, 2024 10:46
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8b3560) 97.88% compared to head (d6c607d) 97.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1158   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files         109      109           
  Lines        7879     7905   +26     
=======================================
+ Hits         7712     7738   +26     
  Misses        167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nogates nogates force-pushed the nogates/add-support-for-fed-versions-up-to-2.6 branch 2 times, most recently from 8e9153c to 2d8f466 Compare February 14, 2024 11:23
@nogates nogates force-pushed the nogates/add-support-for-fed-versions-up-to-2.6 branch from 2d8f466 to 5756af1 Compare February 14, 2024 11:44
@nogates
Copy link
Contributor Author

nogates commented Feb 15, 2024

@rafalp Could you have a look when you got a sec? 🙏

@nogates
Copy link
Contributor Author

nogates commented Feb 15, 2024

ready for another review @rafalp. Thanks!

@rafalp rafalp merged commit 1698ed5 into mirumee:main Feb 15, 2024
22 checks passed
@rafalp
Copy link
Collaborator

rafalp commented Feb 15, 2024

Thanks!

@rafalp rafalp added this to the Next release milestone Feb 15, 2024
@nogates nogates deleted the nogates/add-support-for-fed-versions-up-to-2.6 branch February 16, 2024 06:36
@nogates
Copy link
Contributor Author

nogates commented Feb 16, 2024

Thanks @rafalp ! May I ask, when are you planning in creating a release? Happy to create a PR to fill in the CHANGELOG if that helps! Thanks!

@rafalp
Copy link
Collaborator

rafalp commented Feb 16, 2024

When its ready™ Goal is to have query execution over GET in next Ariadne release. When that's merged, I'll cut out a release.

@nogates
Copy link
Contributor Author

nogates commented Feb 16, 2024

Awesome, thank you!

@nogates
Copy link
Contributor Author

nogates commented Mar 18, 2024

Hey @rafalp !
Any chance we can release a new version soon? We are running fed 2.6 in almost all our subgraphs for a while now, and the python ones are the only one missing :) Let me know if there is anyway I can help you.
thanks

@rafalp
Copy link
Collaborator

rafalp commented Mar 18, 2024

It was already part of 0.23 beta 1, but I'll ship final thing today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants