Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix websockets tests for new Starlette #1151

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fix websockets tests for new Starlette #1151

merged 1 commit into from
Feb 5, 2024

Conversation

rafalp
Copy link
Collaborator

@rafalp rafalp commented Feb 5, 2024

Starlette changed WebSocketDisconnect which prevents pytest's pytest.raises(..., match="") to work anymore.

@rafalp rafalp added this to the Next release milestone Feb 5, 2024
@rafalp rafalp self-assigned this Feb 5, 2024
@rafalp rafalp merged commit 146e7d7 into main Feb 5, 2024
20 checks passed
@rafalp rafalp deleted the fix-starlette-ws-tests branch February 5, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rafalp rafalp

Labels
None yet
Projects
None yet
Milestone
0.23
Development

Successfully merging this pull request may close these issues.
1 participant
@rafalp