Skip to content
This repository has been archived by the owner on Oct 25, 2022. It is now read-only.

Update dependencies and Ember #59

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Conversation

charlesdemers
Copy link
Member

@charlesdemers charlesdemers commented Nov 6, 2020

📖 Description

It’s been a while since the last time we updated the dependencies! So... sorry for the big diff 😬 I’ll try and explain everything that’s changed so that you can review things more efficiently:

  1. Update dependencies in package.json
  2. Format files with new Prettier version. I also changed the config to avoid changing too much things and keep our defaults
  3. Update ember-cli-typescript and TypeScript itself, some types and configs had to be changed to make this work
  4. Update the graphQL stack: apollo-client and friends becomes @apollo/client
  5. Update node.js and npm versions
  6. I moved services/apollo.ts to services/-apollo.ts and imported it through services/apollo.js to avoid the build problem described here: Docs: add info about merged app directory typed-ember/ember-cli-typescript#780
  7. I sneaked a little code change: rename session/fetcher to session to get rid of the pattern of splitting services by action since we don’t do it anymore!

@mirego-builds
Copy link

🦀 Requesting reviewers for this pull request:

  • @remi (contributor with 0 commits in the last 90 days and 69 commits overall)

@mirego-builds mirego-builds requested a review from remi November 6, 2020 02:29
@charlesdemers charlesdemers force-pushed the update/dependencies-and-ember branch from 559f427 to 04f10b2 Compare November 6, 2020 02:31
@charlesdemers charlesdemers force-pushed the update/dependencies-and-ember branch from 04f10b2 to fe00c54 Compare November 6, 2020 02:34
@charlesdemers charlesdemers requested a review from pboutin November 6, 2020 02:39
Makefile Show resolved Hide resolved
.prettierrc Show resolved Hide resolved
.prettierrc Outdated Show resolved Hide resolved
@charlesdemers charlesdemers merged commit 2a4ba3b into master Nov 6, 2020
@charlesdemers charlesdemers deleted the update/dependencies-and-ember branch November 6, 2020 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants