Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

friend declarations in big.h and zzn.h #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

micharu123
Copy link

Friends declared in a header file cannot include default parameter arguments without a function definition. So we should forward declare friends in the header. This change addresses compiler errors due to clang strictness on OS X.

…guments without a function definition. So we should forward declare friends in the header.
fabrice102 added a commit to fabrice102/libscapi that referenced this pull request Jul 21, 2017
Necessary to support macOS.
@@ -209,3 +209,5 @@ extern ZZn one(void);

#endif

// Forward Declaration for friend declaration to allow definition in cpp.
ZZn luc(const ZZn&, const Big&, ZZn* b3=NULL);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This forward declaration should be moved before #endif.

Copy link

@fabrice102 fabrice102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes. They are very useful.

Please see my comment about luc above.

fabrice102 added a commit to fabrice102/libscapi that referenced this pull request Jul 22, 2017
liorko87 added a commit to cryptobiu/libscapi that referenced this pull request Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants