[pull] master from buildroot:master #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Hardware/platform abstraction service for TPMs, HSMs, and Root of Trust https://github.com/parallaxsecond/parsec.git Signed-off-by: Saeed Kazemi <[email protected]> [Julien: add upstream patch to fix build] Signed-off-by: Julien Olivain <[email protected]>
Commit ed12e2f (package/libvirt: add lxc and qemu options) introduced the definition of the 'qemu' user when the libvirt daemon is enabled, but unconditionally uses that user in its permissions table. When enabling libvirt without its qemu support, for example with the commands: cat <<EOF >.config BR2_aarch64=y BR2_PACKAGE_LIBVIRT=y BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y BR2_TARGET_ROOTFS_EXT2=y BR2_TOOLCHAIN_EXTERNAL=y EOF make olddefconfig make The build fails with output: >>> Generating filesystem image rootfs.ext2 ... makedevs: unknown user name: qemu Move the permissions needing the 'qemu' user under the same condition the 'qemu' user is defined under. It means that a few permissions needing root must also be moved, as they belong under a directory needing the 'qemu' user. It also moves a few qemu-related permissions introduced in that same commit. The list of qemu permissions is reordered alphabetically (the others are left unchanged). Of course, it also requires that the qemu-related directory and symlink be moved under the same condition as well. Reported-by: Alessandro <[email protected]> Signed-off-by: Yann E. MORIN <[email protected]> Cc: Jared Bents <[email protected]> [Julien: add the commands to reproduce the issue] Signed-off-by: Julien Olivain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )