-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scheduler folder structure #3883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Only the schedulers.schedulers
package is a bit confusing, but not blocking for now
Thanks for checking. Yeah I agree, I'm open to suggestions. |
Co-authored-by: ammar92 <[email protected]>
Co-authored-by: ammar92 <[email protected]>
Checklist for QA:
What works:Onboarding works, added an extra hostname and enabled some additional boefjes. Scheduled a report which runs on the every minute interval as expected. Subreports can be opened and the main report as well. Aggregate report can be generated. Stopped the scheduler to see what would break. Reports can still be opened and on the Tasks page the expected Error messages are shown. What doesn't work:n/a Bug or feature?:n/a |
* main: Increase max number of PostgreSQL connections (#3889) Fix for task id as valid UUID (#3744) Add `auto_calculate_deadline` attribute to Scheduler (#3869) Ignore specific url parameters when following location headers (#3856) Let mailserver inherit l1 (#3704) Change plugins enabling in report flow to checkboxes (#3747) Fix rocky katalogus tests and delete unused fixtures (#3884) Enable/disable scheduled reports (#3871)
Quality Gate failedFailed conditions |
* main: (64 commits) Bug fix: KAT-alogus parameter is now organization member instead of organization code (#3895) Remove sigrid workflows (#3920) Updated packages (#3898) Fix mula migrations Debian package (#3919) Adds loggers to report flow (#3872) Add additional check if task already run for report scheduler (#3900) Create separate finding for Microsoft RDP port (#3882) fix: 🐛 allow boefje completion with 404 (#3893) Feature/improve rename bulk modal (#3885) Update scheduler folder structure (#3883) Translations update from Hosted Weblate (#3870) Increase max number of PostgreSQL connections (#3889) Fix for task id as valid UUID (#3744) Add `auto_calculate_deadline` attribute to Scheduler (#3869) Ignore specific url parameters when following location headers (#3856) Let mailserver inherit l1 (#3704) Change plugins enabling in report flow to checkboxes (#3747) Fix rocky katalogus tests and delete unused fixtures (#3884) Enable/disable scheduled reports (#3871) optimize locking in katalogus.py, reuse available data (#3752) ...
Changes
Refactoring of folders, cherry-picked from #3839 to make that PR a bit more easier to review in the future.
alembic/
migrations intostorage/
Movedresulted in build-docs problems, left it inconfig/
intocontext/
config/
connectors/
toclients/
listeners
/ toamqp
/services/
tohttp/
queues/
intoschedulers/
rankers/
intoschedulers/
From:
To:
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.