-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds loggers to report flow #3872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest looking at the code base on how we currently deal with the logs and event codes. See for example the constants defined in octopoes/octopoes/types.py
, similar constants can be defined in rocky/reports/views/mixins.py
and rocky/rocky/scheduler.py
. Also note that event codes are currently implemented as integers, so prefixing with 0 and sending them out as strings is wrong. For example and in the style of the already existing logs, "080071"
would be something like 800071
@ammar92 This was based on a conversation with @underdarknl, who said that the event codes had to be strings instead of integers and that they had to start with a "0" (like how it's written here #3043 (comment)). @underdarknl, what do you think? |
Moved from QA to blocked as it's waiting for input from @underdarknl . |
Lets continue with Integers for now. The spec mentions 'codes', the examples have Codes with a leading zero, but beyond that there's no immediate value to making them into strings I think. |
Quality Gate passedIssues Measures |
Changes
This PR adds some loggers to the report flow.
Event codes can be found here: #3043 (comment)
Issue link
Closes ...
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.