Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a timeout to Octopoes' XTDB client #3773

Closed
wants to merge 2 commits into from

Conversation

originalsouth
Copy link
Contributor

Changes

Add a timeout to Octopoes' XTDB client

Issue link

N/A

Demo

N/A

QA notes

Not needed


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@originalsouth originalsouth added octopoes Issues related to octopoes xtdb labels Oct 30, 2024
@originalsouth originalsouth requested a review from a team as a code owner October 30, 2024 20:41
Copy link

base_url=base_url,
headers={"Accept": "application/json"},
transport=(httpx.HTTPTransport(retries=3)),
timeout=60,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to suggest making the httpx timeouts an env variable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, look for similar options in other places.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was already working on doing that in other places, so I can also include the xtdb client in my PR.

@originalsouth
Copy link
Contributor Author

@dekkers will attend to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
octopoes Issues related to octopoes xtdb
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants