Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions to katalogus #3545

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Conversation

stephanie0x00
Copy link
Contributor

Changes

All boefjes and normalizers in the Katalogus now have a description field and are updated to make it more clear what the boefje/normalizer does.

Issue link

Closes: #3539

Demo

image

QA notes

I think I got all normalizers and boefjes. If I forgot any obscure ones let me know. :)


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@stephanie0x00 stephanie0x00 requested a review from a team as a code owner September 17, 2024 14:22
ammar92
ammar92 previously approved these changes Sep 17, 2024
@underdarknl underdarknl merged commit b908beb into main Sep 26, 2024
11 checks passed
@underdarknl underdarknl deleted the feat/add-katalogus-descriptions branch September 26, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update Katalogus descriptions boefjes and normalizers
3 participants