-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Wappalyzer #2727
Replace Wappalyzer #2727
Conversation
65b4f54
to
7fb65be
Compare
# Conflicts: # boefjes/boefjes/plugins/kat_webpage_analysis/analyze_page/normalizer.json # boefjes/boefjes/plugins/kat_webpage_analysis/boefje.json # boefjes/boefjes/plugins/kat_website_software/boefje.json
This reverts commit 7cd4495.
boefjes/boefjes/plugins/kat_webpage_analysis/analyze_page/normalizer.json
Outdated
Show resolved
Hide resolved
Seems to work as advertised. |
… feature/replace-wappalyzer
Looks good to me, moved to QA |
Checklist for QA:
What works:The new Wappalyzer works as expected, when scanned against mispo.es both 36 findings are shown on the main branch compared to this branch (DNS, nmap TCP, wappalyzer and webpage analysis boefjes are enabled). What doesn't work:For another added domain the number of findings are different 61 (this branch) vs 69 (main) findings when scanning mispo.es and an additional domain. The difference appears to be in the identification of some jQuery findings for the additional domain. My guess is that the javascript files are not detected based on the extension for the additional domain, as the javascript files have a .gjs extension. Bug or feature?:See above. |
Good observation and thanks for the review. The new implementation is not a fully compatible replacement for the current implementation, so (minor) differences are expected. |
Co-authored-by: Jan Klopper <[email protected]> Co-authored-by: Jeroen Dekkers <[email protected]>
Changes
This implements python-Wappalyzer that replaces the Wappalyzer boefje and normalizer. Unfortunately, the most recent version of that package has not yet been released on pypi, hence the git dependency in the pyproject file.
Issue link
Closes #2533
Code Checklist
Communication
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.