Merge pull request #647 from minvws/security/c2-log-level

C2: Loggin to much sensitive info
minvws · Jul 22, 2021 · b657194 · b657194
2 parents 8c5a51b + c482824
commit b657194
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/Sources/CTR/Infrastructure/Utilities/Logging.swift b/Sources/CTR/Infrastructure/Utilities/Logging.swift
@@ -155,7 +155,7 @@ public final class LogHandler: Logging {
 
 		isSetup = true
 
-		let level = Bundle.main.infoDictionary?["LOG_LEVEL"] as? String ?? "debug"
+		let level = Bundle.main.infoDictionary?["LOG_LEVEL"] as? String ?? "error"
 
 		switch level {
 			case "verbose":

diff --git a/project.yml b/project.yml
@@ -78,15 +78,6 @@ settings:
     LD_RUNPATH_SEARCH_PATHS:
       - "$(inherited)"
       - "@executable_path/Frameworks"
-  configs:
-    Development:
-      LOG_LEVEL: debug
-    FirebaseAcceptance:
-      LOG_LEVEL: debug
-    FirebaseProduction:
-      LOG_LEVEL: error
-    AppStore:
-      LOG_LEVEL: error
 
 # - Target Templates (i.e. shared default settings for targets):
 
@@ -137,17 +128,22 @@ targetTemplates:
           NETWORK_CONFIGURATION: ACC # bananahalen no longer works.
           CODE_SIGN_IDENTITY: iPhone Developer
           VALIDATE_PRODUCT: NO
+          LOG_LEVEL: debug
         FirebaseAcceptance:
           NETWORK_CONFIGURATION: ACC
+          LOG_LEVEL: error
         FirebaseProduction:
           NETWORK_CONFIGURATION: Production
+          LOG_LEVEL: error
         AppStore:
           NETWORK_CONFIGURATION: Production
+          LOG_LEVEL: error
     info:
       properties:
         # Dynamic properties (APP_FLAVOR etc) here are set at build time, so can still vary based on a Configuration.
         NETWORK_CONFIGURATION: $(NETWORK_CONFIGURATION)
         APP_FLAVOR: ${APP_FLAVOR}
+        LOG_LEVEL: ${LOG_LEVEL}
         CFBundleDevelopmentRegion: nl_NL
         CFBundleExecutable: $(EXECUTABLE_NAME)
         CFBundleName: ${DISPLAY_NAME}