Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the driver #1
Implement the driver #1
Changes from all commits
4c0681c
ad14001
6ede658
c48e7fc
d4ca830
40f600c
0130058
b9f6b6f
e2c230d
c5496ca
cc7683f
6196f75
83f0029
d30dac8
c62968e
75afba4
7574b2b
f153048
d6f8755
70826c5
d82433c
36ba41a
9d39c98
90a18c7
0fb929d
3044bf0
326aecb
580090e
92d5787
386c9ae
d1d21ce
01a8a75
18ef913
2130f2f
7a7e5c2
f2357b2
c36a0dd
302fe66
be08632
b53f9a7
d385eed
c5edb42
6619d75
9730f54
8855250
9a81918
5f52680
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the defaults of this section would result in the developer's inability to run the test suite with a locally started Selenium server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replied to this point already, but I guess it got somehow lost: #1 (comment)
That still stands, the recommended test setup is with docker, therefore the defaults are tailored for docker. In case developers want to customize this, they can easily create their own
phpunit.xml
(that won't be committed with the project).