Removed event dispatcher #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #117 +/- ##
============================================
- Coverage 85.68% 80.84% -4.84%
+ Complexity 351 329 -22
============================================
Files 34 31 -3
Lines 936 851 -85
============================================
- Hits 802 688 -114
- Misses 134 163 +29 ☔ View full report in Codecov by Sentry. |
aik099
force-pushed
the
remove-event-dispatcher
branch
from
289e602 to
0c61839
Compare
aik099
force-pushed
the
remove-event-dispatcher
branch
from
0c61839 to
5dce3df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced usage of event dispatcher with direct object communication.
The decision to use the event dispatcher was incorrect because fired events were caught by all the created test suites and each test suite decided if the event was actually meant for it. In the long run (despite, that such an approach was working) this hindered library maintenance possibilities.