Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test switching to missing window #101

Merged

Conversation

uuf6429
Copy link
Member

@uuf6429 uuf6429 commented Jan 5, 2025

Relates to minkphp/webdriver-classic-driver#10.

Failure is solved by #100.

@aik099
Copy link
Member

aik099 commented Jan 7, 2025

@uuf6429 , for me locally both selenium-based Mink drivers are passing this test. So I guess we can merge it.

@uuf6429
Copy link
Member Author

uuf6429 commented Jan 8, 2025

@aik099 thanks.. note that I only have read access to this repo - I can't approve/merge PRs nor select reviewers (just saying it to be clear that I can't merge this).

@aik099 aik099 merged commit afd1e9d into minkphp:master Jan 8, 2025
1 of 2 checks passed
@aik099
Copy link
Member

aik099 commented Jan 8, 2025

Merging. Thanks @uuf6429 .

@uuf6429 uuf6429 deleted the feature/test-switching-to-missing-window branch January 8, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants