Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updated the driver for the Mink 2.0 API #58

Closed
wants to merge 1 commit into from

Conversation

stof
Copy link
Member

@stof stof commented Dec 29, 2013

@aik099
Copy link
Member

aik099 commented Oct 9, 2014

@stof please update this PR (I guess rebasing will do) so it can be merged automatically at least. Same is true for other Mink 2.x related PR's in other drivers.

@stof
Copy link
Member Author

stof commented Oct 9, 2014

Well, before merging it, we would have to merge things in Mink first. And I have an idea which could help having a single version of the driver for Mink 1.x and 2.x (thanks to a change in CoreDriver) to make the transition easier (allowing us to make improvements on drivers which would be usable for Mink 1.x as well), but I want to experiment with it.

@stof
Copy link
Member Author

stof commented Oct 9, 2014

for reference, the Mink PR is now actually at https://github.com/Behat/Mink/pull/542

@aik099
Copy link
Member

aik099 commented Oct 9, 2014

... allowing us to make improvements on drivers which would be usable for Mink 1.x as well ...

I guess we'll be changing a driver to return xpath instead of NodeElement at all times (as in Mink 2.x) but for Mink 1.x we'll create a layer between driver and mink that will do the wrapping in NodeElement.

@stof
Copy link
Member Author

stof commented Oct 9, 2014

I guess we'll be changing a driver to return xpath instead of NodeElement at all times (as in Mink 2.x) but for Mink 1.x we'll create a layer between driver and mink that will do the wrapping in NodeElement.

My idea is indeed to implement find in the CoreDriver, with a protected abstract method doing the actual finding returning XPath (the 2.x API), and doing the building of NodeElement in the CoreDriver. This way, any driver using this method instead of implementing find() directly would be compatible with both versions

@stof
Copy link
Member Author

stof commented Feb 4, 2015

Closing in favor of #123 as the change done in 1.7 means that drivers don't have anything to change for 2.0 anymore

@stof stof closed this Feb 4, 2015
@stof stof deleted the 2.x-experimental branch February 4, 2015 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants