Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite timeout handling code to support Selenium Server 3 #400

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Nov 2, 2024

  1. Instead of supplying developer-provided timeout type directly to the Selenium Server as-is perform some validation as done in https://github.com/minkphp/webdriver-classic-driver .
  2. Wrap WebDriver's TimeoutException and ScriptTimeoutException exceptions into DriverException, when the page wasn't opened due to page load/pageLoad timeout being met.
  3. The pageLoad timeout wasn't working with Google Chrome on Selenium Server 3.

Closes #397

@aik099 aik099 force-pushed the timeout-setting-code-rewrite branch from e5ab502 to 49ddad3 Compare November 2, 2024 17:14
@aik099
Copy link
Member Author

aik099 commented Nov 4, 2024

I've liked the deprecation of the page load and pageLoad timeout types from minkphp/webdriver-classic-driver#38 and probably will port in here as well.

@aik099 aik099 marked this pull request as ready for review November 11, 2024 10:25
@aik099
Copy link
Member Author

aik099 commented Nov 11, 2024

I've liked the deprecation of the page load and pageLoad timeout types from minkphp/webdriver-classic-driver#38 and probably will port in here as well.

Done.

@aik099 aik099 merged commit c5edd67 into minkphp:master Nov 11, 2024
2 of 10 checks passed
@aik099 aik099 deleted the timeout-setting-code-rewrite branch November 11, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "TimeoutTest::testInvalidTimeoutSettingThrowsException" test fails on Selenium 3.x
1 participant