Merge pull request #380 from aik099/selenium3-timeout-fix

Improve "Selenium2Driver::applyTimeouts" error handling for Selenium 3 support
minkphp · Jun 28, 2024 · 897e7d7 · 897e7d7
2 parents a56db27 + 2fe6b36
commit 897e7d7
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/Selenium2Driver.php b/src/Selenium2Driver.php
@@ -14,6 +14,7 @@
 use Behat\Mink\KeyModifier;
 use Behat\Mink\Selector\Xpath\Escaper;
 use WebDriver\Element;
+use WebDriver\Exception\InvalidArgument;
 use WebDriver\Exception\NoSuchElement;
 use WebDriver\Exception\StaleElementReference;
 use WebDriver\Exception\UnknownCommand;
@@ -372,6 +373,10 @@ private function applyTimeouts(): void
                 $this->getWebDriverSession()->timeouts($type, $param);
             }
         } catch (UnknownError $e) {
+            // Selenium 2.x.
+            throw new DriverException('Error setting timeout: ' . $e->getMessage(), 0, $e);
+        } catch (InvalidArgument $e) {
+            // Selenium 3.x.
             throw new DriverException('Error setting timeout: ' . $e->getMessage(), 0, $e);
         }
     }