Upgrade to BrowserKitDriver v2 and Goutte 4

Goutte 4 is a shortcut for using the Symfony components and does not need custom logic anymore.
minkphp · Dec 17, 2021 · 2605e73 · 2605e73
1 parent 220b696
commit 2605e73
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 99 deletions.
diff --git a/README.md b/README.md
@@ -19,7 +19,7 @@ require "vendor/autoload.php";
 use Behat\Mink\Mink,
     Behat\Mink\Session,
     Behat\Mink\Driver\GoutteDriver,
-    Behat\Mink\Driver\Goutte\Client as GoutteClient;
+    Goutte\Client as GoutteClient;
 
 $mink = new Mink(array(
     'goutte' => new Session(new GoutteDriver(new GoutteClient())),
@@ -39,8 +39,8 @@ Add a file composer.json with content:
 ``` json
 {
     "require": {
-        "behat/mink":               "~1.5",
-        "behat/mink-goutte-driver": "~1.0"
+        "behat/mink":               "^1.9",
+        "behat/mink-goutte-driver": "^2.0"
     }
 }
 ```

diff --git a/composer.json b/composer.json
@@ -16,8 +16,8 @@
 
     "require": {
         "php":                           ">=7.2",
-        "behat/mink-browserkit-driver":  "~1.2@dev",
-        "fabpot/goutte":                 "~1.0.4|~2.0|~3.1"
+        "behat/mink-browserkit-driver":  "^2.0@dev",
+        "fabpot/goutte":                 "^4.0"
     },
 
     "require-dev": {

diff --git a/src/Goutte/Client.php b/src/Goutte/Client.php
@@ -11,33 +11,10 @@
 namespace Behat\Mink\Driver\Goutte;
 
 use Goutte\Client as BaseClient;
-use Symfony\Component\BrowserKit\Response;
 
 /**
  * Client overrides to support Mink functionality.
  */
 class Client extends BaseClient
 {
-    /**
-     * Reads response meta tags to guess content-type charset.
-     *
-     * @param Response $response
-     *
-     * @return Response
-     */
-    protected function filterResponse($response)
-    {
-        $contentType = $response->getHeader('Content-Type');
-
-        if (!$contentType || false === strpos($contentType, 'charset=')) {
-            if (preg_match('/\<meta[^\>]+charset *= *["\']?([a-zA-Z\-0-9]+)/i', $response->getContent(), $matches)) {
-                $headers = $response->getHeaders();
-                $headers['Content-Type'] = $contentType.';charset='.$matches[1];
-
-                $response = new Response($response->getContent(), $response->getStatus(), $headers);
-            }
-        }
-
-        return parent::filterResponse($response);
-    }
 }
diff --git a/src/GoutteDriver.php b/src/GoutteDriver.php
@@ -10,7 +10,6 @@
 
 namespace Behat\Mink\Driver;
 
-use Behat\Mink\Driver\Goutte\Client as ExtendedClient;
 use Goutte\Client;
 
 /**
@@ -27,56 +26,6 @@ class GoutteDriver extends BrowserKitDriver
      */
     public function __construct(Client $client = null)
     {
-        parent::__construct($client ?: new ExtendedClient());
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function setBasicAuth($user, $password)
-    {
-        if (false === $user) {
-            $this->getClient()->resetAuth();
-
-            return;
-        }
-
-        $this->getClient()->setAuth($user, $password);
-    }
-
-    /**
-     * Gets the Goutte client.
-     *
-     * The method is overwritten only to provide the appropriate return type hint.
-     *
-     * @return Client
-     */
-    public function getClient()
-    {
-        return parent::getClient();
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function reset()
-    {
-        parent::reset();
-        $this->getClient()->resetAuth();
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    protected function prepareUrl($url)
-    {
-        $parts = parse_url($url);
-        if (isset($parts['user']) || isset($parts['pass'])) {
-            $this->setBasicAuth(
-                isset($parts['user']) ? $parts['user'] : '',
-                isset($parts['pass']) ? $parts['pass'] : ''
-            );
-        }
-        return $url;
+        parent::__construct($client ?? new Client());
     }
 }
diff --git a/tests/Custom/InstantiationTest.php b/tests/Custom/InstantiationTest.php
@@ -3,6 +3,7 @@
 namespace Behat\Mink\Tests\Driver\Custom;
 
 use Behat\Mink\Driver\GoutteDriver;
+use Goutte\Client;
 use PHPUnit\Framework\TestCase;
 
 class InstantiationTest extends TestCase
@@ -23,6 +24,6 @@ public function testInstantiateWithoutClient()
     {
         $driver = new GoutteDriver();
 
-        $this->assertInstanceOf('Behat\Mink\Driver\Goutte\Client', $driver->getClient());
+        $this->assertInstanceOf(Client::class, $driver->getClient());
     }
 }
diff --git a/tests/GoutteConfig.php b/tests/GoutteConfig.php
@@ -23,22 +23,4 @@ protected function supportsJs()
     {
         return false;
     }
-
-    public function skipMessage($testCase, $test)
-    {
-        if (
-            'Behat\Mink\Tests\Driver\Form\Html5Test' === $testCase
-            && in_array($test, array(
-                'testHtml5FormAction',
-                'testHtml5FormMethod',
-            ))
-            && !method_exists('Symfony\Component\DomCrawler\Tests\FormTest', 'testGetMethodWithOverride')
-            // Symfony 4.4 removed tests from dist archives, making the previous detection return a false-positive
-            && !method_exists('Symfony\Component\DomCrawler\Form', 'getName')
-        ) {
-            return 'Mink Goutte doesn\'t support HTML5 form attributes before Symfony 3.3';
-        }
-
-        return parent::skipMessage($testCase, $test);
-    }
 }