Removed the BC layers for Symfony 2.2 and older #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note that we already dropped the testing for these versions a while ago (we rely on Silex for the testsuite, and it does not support these Symfony versions anymore) |
|
This is a cherry-pick of the second commit of #44 btw. |
|
I think, that first we need to release next minor driver version with update for supporting new |
|
@aik099 do we need 2 different minor versions for these ? |
stof
force-pushed
the
bump_symfony_deps
branch
from
0062335 to
abcdf72
Compare
|
I'm not sure at 100%. Removing compatibility is BC break after all. |
|
@aik099 I'm removing the compatibility for versions which are unmaintained since more than 1 year (I'm talking about the end for security maintenance). |
|
OK. |
stof
added a commit
that referenced
this pull request
Feb 21, 2015
Removed the BC layers for Symfony 2.2 and older
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 2.2 is EOLed since 1 year: http://symfony.com/roadmap?version=2.2#checker
I think we can be fine with dropping the support for it in the next minor version of the driver (1.3.0) rather than bumping the major version.
People using Mink inside Behat already lost the compatibility with these unmaintained Symfony versions anyway btw, and I don't think anyone should be using unmaintained versions, so it is acceptable IMO (people who don't update their Symfony dependency will be fine with not updating their Mink driver anyway)